Cards in decks with images #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to say : ajax and JSON works for me only with full version of jquery.js, |
|
Sure enough, mtgatracker is using a super stripped version of jquery: I'm sure I had a good reason for this, but it really escapes me at the moment. |
|
Spencer, did you happen to remember what the reason for the stripped jQuery is? Had another request for images on hover, so merging this (well, making it hover then merging) would be nice if there isn't really a strong reason to strip out jquery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click on card - show image. Click again - hide.
Image urls are generating with api of www.scryfall.com by arena card id.
2 faces cards works too.
Some code is from sorting patch.