Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlib.request has the wrong output? or is jupyter understanding #182

Open
Kreijstal opened this issue Nov 19, 2024 · 4 comments · May be fixed by #183
Open

urlib.request has the wrong output? or is jupyter understanding #182

Kreijstal opened this issue Nov 19, 2024 · 4 comments · May be fixed by #183

Comments

@Kreijstal
Copy link

Kreijstal commented Nov 19, 2024 •
edited
Loading

msys2/MINGW-packages#21139

Bug report

cpython-mingw/Lib/nturl2path.py

Line 45 in d21f60d

def pathname2url(p): 

>>> from urllib.request import pathname2url
>>> pathname2url("C:/Users/kreij/AppData/Roaming/jupyter/runtime/jpserver-18504-open.html")
'///C://Users/kreij/AppData/Roaming/jupyter/runtime/jpserver-18504-open.html'

While the output should be
'//C:/Users/kreij/AppData/Roaming/jupyter/runtime/jpserver-18504-open.html'
With 3 '/' aka file:/// no browser gets launched

On my computer when I open explorer.exe and insert
file:///C://Users/kreij/AppData/Roaming/jupyter/runtime/jpserver-18504-open.html
nothing happens, but when I insert
file://C:/Users/kreij/AppData/Roaming/jupyter/runtime/jpserver-18504-open.html
a browser gets launched

Fixing this would fix the jupyter problem

Your environment

mingw64
@Kreijstal Kreijstal changed the title urlib.request has the wrong output urlib.request has the wrong output? or is jupyter understanding Nov 19, 2024
This was referenced Nov 19, 2024
Open
Open
@Kreijstal Kreijstal mentioned this issue Dec 8, 2024
Closed
@barneygale
Copy link

I believe three leading slashes is correct for DOS drive URLs, see RFC 8089 / wikipedia

@Kreijstal
Copy link
Author

I believe three leading slashes is correct for DOS drive URLs, see RFC 8089 / wikipedia

you are right /// works but C:// is the one causing the error.

@barneygale
Copy link

I think that might have been fixed here: python#126214

Could you try in CPython main?

@Kreijstal
Copy link
Author

Kreijstal commented Dec 8, 2024 •
edited
Loading

I think that might have been fixed here: python#126214

Could you try in CPython main?

yeah, it was already fixed, I retract the PR
Thank you very much, and sorry for wasting time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pathname2url: normalize forward slashes to backslashes before processing Kreijstal/cpython-mingw
2 participants
@barneygale @Kreijstal