Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dts: add Samsung Galaxy Grand Max grandmaxltekx (SM-G720N0) #323

Open
HPotty36 opened this issue Feb 10, 2024 · 4 comments
Open

dts: add Samsung Galaxy Grand Max grandmaxltekx (SM-G720N0) #323

HPotty36 opened this issue Feb 10, 2024 · 4 comments

Comments

@HPotty36
Copy link

HPotty36 commented Feb 10, 2024 •
edited
Loading

I flashed the lk2nd image file on my SM-G720N0 hoping it works just like SM-G720AX, but the fastboot commands don't work at all. Please add support for the Korean variants. Thanks in advance!
@TravMurav
Copy link
Member

Hi!

You would need to add your device model to lk2nd similar to this:

lk2nd/dts/msm8916/msm8916-samsung-r04.dts

Lines 79 to 88 in e7eb070

grandmaxlteub {
model = "Samsung Galaxy Grand Max (SM-G720AX)";
compatible = "samsung,grandmaxlteub", "qcom,msm8916", "lk2nd,device";
lk2nd,match-bootloader = "G720AX*";
samsung,muic-reset {
i2c-gpio-pins = <105 106>;
i2c-address = <0x14>;
};
};

You should see a DTB line on screen, use the last value it shows to know which file to add it to. I.e. if it says 0x04 then you add to msm8916-samsung-r04.dts.

@wonderfulShrineMaidenOfParadise
Copy link
Contributor

Cc @third-tester

@wonderfulShrineMaidenOfParadise
Copy link
Contributor

wonderfulShrineMaidenOfParadise commented Feb 28, 2024 •
edited
Loading

There is already a dts done, but somehow not submitted.
You can also squash, clean up, rebase and then push the branch.

https://github.com/third-tester/lk2nd/tree/grandmaxltekx outdated

@wonderfulShrineMaidenOfParadise
Copy link
Contributor

Consider joining #msm8916-mainline:matrix.org for faster helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TravMurav @wonderfulShrineMaidenOfParadise @HPotty36