Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Based-on: #15

Open
akihikodaki opened this issue Dec 13, 2023 · 3 comments
Open

Support Based-on: #15

akihikodaki opened this issue Dec 13, 2023 · 3 comments

Comments

@akihikodaki
Copy link
Contributor

Hi,

I'm trying out b4 since I have been recently contributing to Linux and am currently using it for QEMU development too. It works well for QEMU as well.

One thing I miss though is the support for Based-on:, which is a tag to denote the dependency series.
https://qemu.readthedocs.io/en/v8.1.0/devel/submitting-a-patch.html#base-patches-against-current-git-master

It's somewhat specific to QEMU so it may not be in the main scope of this tool, but let me open an issue just for record.
@marcosps
Copy link
Contributor

marcosps commented Feb 2, 2024 •
edited
Loading

@akihikodaki the current version of b4 adds a base-commit in the cover-letter, as you can see in this patchset that I sent some time ago.

Maybe it's just a question of wording in this case? @mricon do you think that Based-on is better than base-commit, or can it be configured?

@akihikodaki
Copy link
Contributor Author

@marcosps @mricon Based-on: uses Message-Id, so you can easily look up the base series on lore.kernel.org, for example. Is it possible with base-commit?

@marcosps
Copy link
Contributor

marcosps commented Feb 5, 2024

@marcosps @mricon Based-on: uses Message-Id, so you can easily look up the base series on lore.kernel.org, for example. Is it possible with base-commit?

I believe that base-commit is just the commit hash =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcosps @akihikodaki