Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fallback for alphaToCoverage if antialias is disabled #29395

Merged

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #29269

Description

Safeguarded the renderer from breaking when alphaToCoverage is used without multisampling. For example InstancedPointsNodeMaterial would break by default if the renderer didn't have antialias enabled.

This contribution is funded by Utsubo

Copy link

github-actions bot commented Sep 12, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.83
169.75
685.83
169.75
+0 B
+0 B
WebGPU 832.14
222.98
832.25
223
+115 B
+18 B
WebGPU Nodes 831.65
222.86
831.76
222.88
+115 B
+18 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.42
111.53
462.42
111.53
+0 B
+0 B
WebGPU 529.9
142.75
529.97
142.77
+70 B
+16 B
WebGPU Nodes 486.56
132.61
486.63
132.63
+70 B
+15 B

@sunag sunag modified the milestone: r169 Sep 12, 2024
@aardgoose
Copy link
Contributor

Line2NodeMaterial will also need this.

@RenaudRohlinger
Copy link
Collaborator Author

Indeed! Updated the PR consequently.

@sunag sunag merged commit c85a437 into mrdoob:dev Sep 14, 2024
12 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants