This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix #4665; Sign dev and stage XPIs with the autograph dev-root #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-k
approved these changes
Aug 2, 2018
Makefile
Outdated
| @@ -115,6 +115,9 @@ bootstrap_zip: addon | |||
| unsigned_bootstrap_xpi: bootstrap_zip | |||
| cp build/screenshots-bootstrap.zip build/screenshots.xpi | |||
|
|
|||
| dev_signed_bootstrap_xpi: bootstrap_zip | |||
| curl -v -F "input=@build/screenshots-bootstrap.zip" -o build/screenshots.xpi -H "Authorization: ${AUTOGRAPH_EDGE_TOKEN}" https://autograph-edge.stage.mozaws.net/sign | |||
There was a problem hiding this comment.
Will -v result in the token being logged? Maybe we could pipe through sed or grep -v to filter it out and retain verbose output.
There was a problem hiding this comment.
Good catch. Let's see how far we can get without the -v
jaredhirsch
force-pushed
the
4665-sign-dev-xpi
branch
from
da73472 to
792e11a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@g-k Mind taking a look? Not sure how I can verify the built xpi is really signed until this lands in master. Suggestions welcome :-)