Window Polish on Windows #10097
Merged
Window Polish on Windows #10097
+157
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added WindowsUtils.cpp and WindowsUtils.h to handle Windows-specific utilities. - Implemented setTitleBarIcon and setDockIcon methods in WindowsUtils.cpp to set the title bar and dock icon images for the application. - Updated Theme.cpp to handle Windows-specific theme settings. - Added a new method getTitleBarIcon in Theme.cpp to return the title bar icon image.
- Added a new function `updateTitleBarColor` to set the title bar color based on the current theme. - Updated `setTitleBarIcon` to use the new `updateTitleBarColor` function. - Added a new function `forceWindowRedraw` to force a window redraw. - Updated `setDockIcon` to use the new `forceWindowRedraw` function. -
- Added a call to `WindowsUtils::forceWindowRedraw(window)` in the `run()` method of `CommandUI` to ensure the window is redrawn when the theme changes. - This ensures that the window decorations are updated to match the new theme, providing a more consistent and visually appealing user experience.
strseb
force-pushed
the
basti/design_nits
branch
from
0dbd01f to
c822e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Designers aren't looking quick lets change some things.
IMHO RN our Window on Windows has multiple issues:
❌ The Titlebar shows a very pixelated icon
❌ The Icon is not the one in our figma windows "window"
❌ The Titlebar is not responsive to neither theme / sys prefrence
❌ The Titlebar is not using the same background as the client app
Whenever this opens on windows it looks ... cheap, especially the title bar not beeing part of the client space, looks outdated. It's giving cross plattform electron app.
So today i needed a fun break.
So this pr adds a theme listener, that:
✅ Updates the Titlebar to the Themes BG color
✅ Render icon from the SVG, respecting the coloscheme
✅ Set that icon for the window only.