feat: Allow passing in local and remote socket addresses #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@martinthomson, is this what you had in mind? Fixes #15
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 93.24% 93.30% +0.06%
==========================================
Files 1 1
Lines 222 269 +47
==========================================
+ Hits 207 251 +44
- Misses 15 18 +3 ☔ View full report in Codecov by Sentry. |
|
Note: This won't be backward-compatible. If you want source compatibility, you'll have to implement |
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
martinthomson
approved these changes
Sep 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@mxinden looks like the semver check works :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinthomson, is this what you had in mind?
Fixes #15