Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[indigo-devel] Modify ikfast_template for getPositionIK single solution results (#537) from kinetic-devel #575

Closed
wants to merge 1 commit into from
Closed

[indigo-devel] Modify ikfast_template for getPositionIK single solution results (#537) from kinetic-devel #575

wants to merge 1 commit into from

Conversation

130s
Copy link
Contributor

@130s 130s commented Aug 7, 2017

@hartmanndennis hartmanndennis mentioned this pull request Aug 10, 2017
Closed
@v4hn
Copy link
Contributor

v4hn commented Aug 16, 2017 •
edited
Loading

Due to #586/#619 the template is broken in indigo at the moment.
Until this is fixed I would like to refrain from further patches.

@v4hn v4hn mentioned this pull request Aug 19, 2017
Merged
@v4hn v4hn added the moveit day candidate This issue can likely be resolved in less than a day label Oct 11, 2017
@v4hn
Copy link
Contributor

v4hn commented Oct 11, 2017

This needs to be tested now that ikfast generation works on indigo again.
Adding WMD label.

@v4hn v4hn mentioned this pull request Dec 10, 2017
Closed
@nsnitish @130s
Modify ikfast_template for getPositionIK single solution results (mov…
ac3de47 
…eit#537)

* Modifeid ikfast_template for getPositionIK single solution case

* Corrected the harmonize definition

* Formated according to style guide and few typos

* Sort the solutions before returning closest

* Removed the dependency of getPositionIK from harmonize

* Removed the dependency of getPositionIK from harmonize

* Used std::sort for solution sorting

* Changed struct name for storing and sorting the solutions
@130s 130s added the Indigo label Dec 24, 2017
@onionsflying onionsflying mentioned this pull request Jan 15, 2018
Open
@henningkayser
Copy link
Member

@130s, @v4hn can we close this PR?

@davetcoleman
Copy link
Member

This is just a cherry-pick of a kinetic fix into indigo. I don't think we should be changing indigo behavior at this point, and this PR is clearly stale. Closing.

@130s 130s deleted the i/cp_536 branch March 14, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
moveit day candidate This issue can likely be resolved in less than a day state unclear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@130s @v4hn @henningkayser @davetcoleman @nsnitish