Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add client side performance tracking #112

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
+360 −4
Open

feat: add client side performance tracking #112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b3c758a
feat: add initial client side performance tracking logic
renanccastro Feb 4, 2024
4c69c31
fix: remove folder
renanccastro Feb 4, 2024
7ab17de
feat: change webvitals to batch
renanccastro Feb 7, 2024
effb1fd
feat: add several more metrics and info
renanccastro Feb 18, 2024
a774402
feat: add several more metrics and info
renanccastro Feb 18, 2024
6e4ff9a
fix: code review comments
renanccastro Feb 21, 2024
4007c15
feat: store metrics as date
renanccastro Feb 22, 2024
0338401
fix: metrics should be an object
renanccastro Feb 22, 2024
95ce8de
feat: use performance api to calculate resources response time and ch…
renanccastro Feb 27, 2024
d0e4aec
fix: fixes on payload and add dynamic import size
renanccastro Mar 1, 2024
0f637b9
feat: add appId to payload
renanccastro Mar 6, 2024
94d9c04
fix: remove optional chaining
renanccastro May 22, 2024
90b868e
fix: lint
renanccastro May 22, 2024
dd2183d
feat: add needed fields
renanccastro Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: lint
  • Loading branch information
@renanccastro
renanccastro committed May 22, 2024
commit 90b868eb8a5285d2f717c4e4d2e913e10d9ff9b5
4 changes: 3 additions & 1 deletion lib/client/hijack/wrapSubscription.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ export function wrapSubscription () {
const onReady = () => {
Kadira.webVitals.completedObjects += 1;
Kadira.webVitals.subs.push({ start, end: Ntp._now() });
oldReady && oldReady();
if (oldReady) {
oldReady();
}
};
callbacks.onReady = onReady;
return oldSubscribe(arguments[0],...params, callbacks);
Expand Down
1 change: 0 additions & 1 deletion lib/client/models/webVitals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ export class WebVitalsModel {
} else {
document.addEventListener('readystatechange', () => {
if (document.readyState === 'complete') {
console.log('COMPLETE');
/* stop tracking new dynamic imports/methods/publications */
this.stopTracking();
}
Expand Down
Loading