Skip to content

Commit

Permalink
Revert "cmd/ebitenmobile: Use the better way to go-get dependencies"
Browse files Browse the repository at this point in the history
This reverts commit ad2d356.

Reason: Installation failed on Windows.

Closes hajimehoshi#1493
  • Loading branch information
hajimehoshi committed Feb 14, 2021
1 parent 9277ac1 commit e110abb
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions cmd/ebitenmobile/gomobile.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,11 @@ func prepareGomobileCommands() error {
return err
}

// To record gomobile and its dependencies to go.sum for Go 1.16 and later, go-get golang.org/x/mobile with `...` (#1487).
// To record gomobile to go.sum for Go 1.16 and later, go-get gomobile instaed of golang.org/x/mobile (#1487).
// This also records gobind as gomobile depends on gobind indirectly.
// Using `...` doesn't work on Windows since mobile/internal/mobileinit cannot be compiled on Windows w/o Cgo (#1493).
// Note that `go mod tidy` doesn't work since this removes all the indirect imports.
if err := runGo("get", "golang.org/x/mobile/...@"+gomobileHash); err != nil {
if err := runGo("get", "golang.org/x/mobile/cmd/gomobile@"+gomobileHash); err != nil {
return err
}
if localgm := os.Getenv("EBITENMOBILE_GOMOBILE"); localgm != "" {
Expand Down

0 comments on commit e110abb

Please sign in to comment.