Replies: 1 comment
-
Agreed - this seems sensible to me too. I think probably having three options rather than a bool is fine here. We can use hinting to make it autocomplete for users. I've converted into an issue for when we get round it it. It's a bit fiddly because, whilst you can directly edit the js, those files are the product of a wider js compilation process, so to do it 'properly' the changes have to be made upstream in other code that's not very well organised. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Is your proposal related to a problem?
The labelling tool defaults to showing the Splink predictions by default, which is acknowledged as potentially introducing bias. We can currently tackle this issue in two ways:
show_splink_predictions_in_interface=False
.The first option is good, and I believe wants to stay. It may not be suitable to allow reviewers even the option to see the predictions, but these tools tend to be for linkage operators and so defaulting
show_splink_predictions_in_interface
to True in in Python land works.The problem with the second option is that the default behaviour of the tool is to show the predictions when loaded and so users may see Splink predictions before being able to toggle the view off. The default value setting returned by the
_show_splink_predictions_initial_value()
function of labelling_tool/slt.js sets a value of "Show splink predictions" if SHOW_SPLINK_PREDICTIONS is not false, causing the view to be visible on page load.splink/splink/internals/files/labelling_tool/slt.js
Lines 8823 to 8832 in 2aa78da
Describe the solution you'd like
Would it be better to have this checkbox default to be off on page load, and then allow users to toggle the checkbox if they want to see the Splink predictions? I updated the
_show_splink_predictions_initial_value
function to the following, which seemed to act as intended:My JS skills aren't really good enough to know for sure if a) it has wider implications and b) makes the function a bit redundant.
Describe alternatives you've considered
In seriousness, I considered whether changing the
show_splink_predictions_in_interface
arg oflinker.labelling_tool_for_specific_record()
from a Boolean to a string might be worthwhile, but this seems unnecessarily complicated.Beta Was this translation helpful? Give feedback.
All reactions