Fix missing push and readme on new tests rules (bitnami-labs#937)

The push was missing and some instructions also regarding the push rule were inaccurate, missing the K8S_CONTEXT env var.
mohamed-essam · Aug 30, 2022 · aa60095 · aa60095
1 parent 99e104c
commit aa60095
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -137,6 +137,7 @@ check-k8s:
 
 push-controller: clean check-k8s controller.image.$(OS)-$(ARCH)
 	docker tag $(CONTROLLER_IMAGE)-$(OS)-$(ARCH) $(CONTROLLER_IMAGE)
+	docker push $(CONTROLLER_IMAGE)
 
 apply-controller-manifests: clean check-k8s controller.yaml
 	kubectl apply -f controller.yaml

diff --git a/docs/developer/controller.md b/docs/developer/controller.md
@@ -81,15 +81,15 @@ make test
 #### Push the controller image
 
 ```bash
-make OS=linux ARCH=amd64 push-controller
+make K8S_CONTEXT=kind-mykind OS=linux ARCH=amd64 push-controller
 ```
 
 This builds the controller container image and pushes it.
 
 Remember that the `REGISTRY` env var is only needed when using a custom registry:
 
 ```bash
-make REGISTRY=localhost:5000 OS=linux ARCH=amd64 push-controller
+make K8S_CONTEXT=kind-mykind REGISTRY=localhost:5000 OS=linux ARCH=amd64 push-controller
 ```
 
 #### Building & applying the controller manifests