Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#7346: Handle execution on Dask workers to avoid creating conflic… #7347

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

FIX-#7346: Handle execution on Dask workers to avoid creating conflic… #7347

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b5f50b9
FIX-#7346: Handle execution on Dask workers to avoid creating conflic…
data-makerman Jul 19, 2024
3d17773
Add tests for FIX-#7346
data-makerman Jul 22, 2024
6eb5442
Update modin/tests/core/storage_formats/pandas/test_internals.py
data-makerman Jul 29, 2024
c6eb900
Fixed linting issues
data-makerman Jul 29, 2024
36e1036
Include fixture in test function for Engine selection
data-makerman Aug 1, 2024
036b91e
Fix linting error due to whitespace
data-makerman Aug 20, 2024
9ff6261
Merge branch 'main' into Fix-#7346--Handle-execution-on-Dask-workers-…
data-makerman Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update modin/tests/core/storage_formats/pandas/test_internals.py 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
  • Loading branch information
@data-makerman @YarShev
data-makerman and YarShev authored Jul 29, 2024
commit 6eb544242aa57511083c8054911f9ce476abcd21
8 changes: 8 additions & 0 deletions modin/tests/core/storage_formats/pandas/test_internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2785,6 +2785,14 @@ def dataframe_test_default_property(df):
):
pd.DataFrame([[1]]).dataframe_test_default_property

@pytest.mark.parametrize(
"modify_config",
[
{Engine: "Ray"},
{Engine: "Dask"},
],
indirect=True,
)
def test_daemonic_worker_protection():
data-makerman marked this conversation as resolved.
Show resolved Hide resolved
# Test for issue #7346, wherein some operations on Dask cause a second submission of a task to
# the Dask client from the worker scope, which should not cause a new client to be created
Expand Down