Remove close of datachan

Closing of the dataChan right after the closeChan can cause a race in select statements. If select attemps the dataChan operation then a panic will happen. Since dataChan is not used for synchronization, the closure of closeChan is enough to stop all data operations. Fixes #60 Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
moby · Dec 4, 2015 · 593dba5 · 593dba5
1 parent 0dd8231
commit 593dba5
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/stream.go b/stream.go
@@ -322,6 +322,5 @@ func (s *Stream) closeRemoteChannels() {
 		close(s.closeChan)
 		s.dataLock.Lock()
 		defer s.dataLock.Unlock()
-		close(s.dataChan)
 	}
 }