[27.x backport] c8d: Multi-platform image list #48346
Merged
+579
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our version of go-swagger doesn't handle the `omitempty` correctly for the new field. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit efb3c50) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 85e9102) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Add `Manifests` field to `ImageSummary` which exposes all image manifests (which includes other blobs using the image media type, like buildkit attestations). There's also a new `manifests` query field that needs to be set in order for the response to contain the new information. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 050afe1) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 469c2ef) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 495fab8) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
The `GET /images/json` requires an optional `container-count` parameter which set the `Containers` property of in the ImageSummary to a number of containers using that image. This was also propagated to the new manifest list property which includes a list of all the container IDs that are using this specific image manifest. Disconnect the `ImageData.Containers` property from this option and always include it by default without an explicit opt-in. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit b93cf37) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
added
area/api
status/2-code-review
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport: c8d: Multi-platform image list #47526
backport: c8d/list: Fix
Totalsize calculation #48330backport: c8d/list: Don't require
opts.ContainerCountfor manifest containers #48345needs: c8d/list: Add test and combine size #47449
related to: UX: improve / design UX for multi-arch images #44582 (comment)
Add the
Manifestsfield toImageSummary.CLI initial implementation: docker/cli#4982
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
