pkg/plugins: some cleaning up (step 2) #46080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/testing
area/plugins
kind/refactor
thaJeztah
changed the title
Add an alias in the pkg/plugins package. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The MediaType was changed twice in; - b3b7eb2 ("application/vnd.docker.plugins.v1+json" -> "application/vnd.docker.plugins.v1.1+json") - 54587d8 ("application/vnd.docker.plugins.v1.1+json" -> "application/vnd.docker.plugins.v1.2+json") But the (integration) tests were still using the old version, so let's use the VersionMimeType const that's defined, and use the updated version. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The MediaType was changed twice in; - b3b7eb2 ("application/vnd.docker.plugins.v1+json" -> "application/vnd.docker.plugins.v1.1+json") - 54587d8 ("application/vnd.docker.plugins.v1.1+json" -> "application/vnd.docker.plugins.v1.2+json") But the (integration) tests were still using the old version, so let's use the VersionMimeType const that's defined, and use the updated version. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The MediaType was changed twice in; - b3b7eb2 ("application/vnd.docker.plugins.v1+json" -> "application/vnd.docker.plugins.v1.1+json") - 54587d8 ("application/vnd.docker.plugins.v1.1+json" -> "application/vnd.docker.plugins.v1.2+json") But the (integration) tests were still using the old version, so let's use the VersionMimeType const that's defined, and use the updated version. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
pkg_plugin_cleanup_STEP2
branch
from
a9720d9 to
3e52785
Compare
|
Rebased to get a fresh run of CI |
cpuguy83
approved these changes
Aug 7, 2023
vvoland
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/plugins: add convenience alias for VersionMimeType
Add an alias in the pkg/plugins package.
integration-cli: use plugin Content-Type headers v1.2
The MediaType was changed twice in;
But the (integration) tests were still using the old version, so let's
use the VersionMimeType const that's defined, and use the updated version.
libnetwork: use plugin Content-Type headers v1.2
same
volume/drivers: use plugin Content-Type headers v1.2
same
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)