Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push image faster by using pigz to compress #44007

Closed
wants to merge 1 commit into from

Conversation

lingoubb
Copy link

- What I did
The gzip compression used in the docker push has poor performance. I changed it to using pigz for compression.
I noticed that docker used pigz to decompress the pull image for better performance (#35697), so I think the performance of docker push can be improved in the same way.

- How I did it
Similar to #35697, this change switches to trying to use pigz for gzip compression. If it isn't available, it'll fall back to the default. This code path can also be disabled by environment variable.

- How to verify it
Performance improvement verification: after the manual push test of some images (from 19.2 MB to 28.2 GB) , the time consumed by pushing images is reduced by 47.9%~74.7%. In fact, I have noticed that some issues have discussed and verified the performance improvement brought by this.
Correctness verification: There are existing tests for this codepath to ensure correctness of this implementation.

- Description for the changelog

Push image faster by using pigz to compress

@lingoubb lingoubb closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant