The returned err should be printed #32167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fine, but maybe as a debug message. |
miaoyq
force-pushed
the
print-a-err-return
branch
from
0e7a157 to
87d0a3a
Compare
|
@cpuguy83 |
Signed-off-by: Yanqiang Miao <miao.yanqiang@zte.com.cn>
allencloud
reviewed
Mar 29, 2017
| @@ -121,6 +121,8 @@ func (d *daemonDiscoveryReloader) advertiseHeartbeat(address string) { | |||
| if err := d.initHeartbeat(address); err == nil { | |||
| ready = true | |||
| close(d.readyCh) | |||
| } else { | |||
| logrus.WithError(err).Debug("First discovery heartbeat failed") | |||
There was a problem hiding this comment.
Shall we print the detailed error, like:
logrus.WithError(err).Debugf("First discovery heartbeat failed: %v", err)
ping @cpuguy83
There was a problem hiding this comment.
This would just be the error string?
There was a problem hiding this comment.
@allencloud WithError(err) will do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yanqiang Miao miao.yanqiang@zte.com.cn