Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bash completion for docker build --add-host #31382

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Add bash completion for docker build --add-host #31382

merged 1 commit into from
Feb 27, 2017

Conversation

albers
Copy link
Member

@albers albers commented Feb 27, 2017

Ref: #30383
Thanks @thaJeztah for the ping.

@albers
Add bash completion for docker build --add-host
8de3eb0 
Signed-off-by: Harald Albers <github@albersweb.de>
cpuguy83
cpuguy83 approved these changes Feb 27, 2017
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Feb 27, 2017
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit ce79f6b into moby:master Feb 27, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Feb 27, 2017
@albers albers deleted the completion-build--add-host branch February 27, 2017 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
17.04.0
Development

Successfully merging this pull request may close these issues.
4 participants
@albers @vdemeester @cpuguy83 @GordonTheTurtle