Tidy GetDockerOS() function #28217
Merged
Tidy GetDockerOS() function #28217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <jhoward@microsoft.com>
|
@thaJeztah Should be a trivial review :) |
|
LGTM |
1 similar comment
|
LGTM |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Tidy GetDockerOS() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
Ticks off the comment by @vdemeester in docker/engine-api#373, when the Docker stats implementation PR #25737 was split between engine-api and docker/docker. By the time the PR actually went in, engine-api was back in the docker/docker repo.
Just moves the GetDockerOS() function to a utils.go file, and doesn't externalise it as that's not required.