-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.11.1 cherry pick #22242
Merged
Merged
1.11.1 cherry pick #22242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlaventure
force-pushed
the
1.11.1-cherry-pick
branch
3 times, most recently
from
April 22, 2016 18:23
7d286ea
to
d3e5e42
Compare
mlaventure
force-pushed
the
1.11.1-cherry-pick
branch
7 times, most recently
from
April 25, 2016 18:09
691f81b
to
d954e85
Compare
Push what should be the last version. PTAL and check that I haven't forgotten anything :) |
@@ -311,7 +311,7 @@ func getDevicesFromPath(deviceMapping containertypes.DeviceMapping) (devs []spec | |||
|
|||
// check if it is a symbolic link | |||
if src, e := os.Lstat(deviceMapping.PathOnHost); e == nil && src.Mode()&os.ModeSymlink == os.ModeSymlink { | |||
if linkedPathOnHost, e := os.Readlink(deviceMapping.PathOnHost); e == nil { | |||
if linkedPathOnHost, e := filepath.EvalSymlinks(deviceMapping.PathOnHost); e == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixing a P3, it has nothing to do in a patch release.
mlaventure
force-pushed
the
1.11.1-cherry-pick
branch
2 times, most recently
from
April 25, 2016 22:08
2160b2f
to
f8ec19b
Compare
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
…fest @nwt noticed that the media type specified in the config section of a schema2 manifest is application/octet-stream, instead of the correct value application/vnd.docker.container.image.v1+json. This brings in distribution/distribution#1622 to fix this. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com> (cherry picked from commit c18d03a)
Docker 1.11 added a feature to set labels on volumes, networks and images (during build), but these changes were not documented in the API documentation. This adds the new features to the documentation. Also fixes some minor formatting, and options that were not used in the examples. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit ba353f3)
RPC connection closing error will be reported every time we shutdown daemon, this error is expected, so we should remove this error to avoid confusion to user. Signed-off-by: Zhang Wei <zhangwei555@huawei.com> (cherry picked from commit a02ae66)
…tainer Don't throw "restartmanager canceled" error for no restart policy container and add the container id to the warning message if a container has restart policy and has been canceled. Signed-off-by: Lei Jitang <leijitang@huawei.com> (cherry picked from commit 494297b)
Auto-creation of non-existing host directories is no longer deprecated (9d5c26b), so this warning is no longer relevant. This removes the deprecation warning. Also removes the "system" package here, because it's only used on non-Windows, so basically just called os.MkdirAll() Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 1d02ad2)
Fixes moby#22030 Because the publisher uses this same value to all the stats endpoints we need to make a copy of this as soon as we get it so that we can make our modifications without it affecting others. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> (cherry picked from commit d17ee4b)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 84d1701)
It should not be an error to call a common option to cancel restarts. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> (cherry picked from commit fc2e223)
Signed-off-by: Madhu Venugopal <madhu@docker.com> (cherry picked from commit de806a6)
Why? Because the `mount` here will sometimes fail when run in `debian:jessie`, which is what the environrment hosting the test suite is running if run from the `Makefile`. Also, why the heck not containerize it, all the things. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 59b83d8)
This fix tries to fix the http panics caused by container deletion with empty names in moby#22210. The issue was because when an empty string was passed, `GetByName()` tried to access the first element of the name string without checking the length. A length check has been added. A test case for moby#22210 has been added. This fix fixes moby#22210. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> (cherry picked from commit 9d8071a)
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage) (cherry picked from commit 829d188) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 7bf0773)
This functionality has been fixed by 7bca932 but then it has been broken again by a793564 and finally refixed here. Basically the functionality was to prompt for login when trying to pull from the official docker hub. Signed-off-by: Antonio Murdaca <runcom@redhat.com> (cherry picked from commit 4316ae2)
Signed-off-by: Michael Crosby <crosbymichael@gmail.com> (cherry picked from commit 199472c)
This avoid an extra bind mount within /var/run/docker/libcontainerd This should resolve situations where a container having the host /var/run bound prevents other containers from being cleanly removed (e.g. moby#21969). Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com> (cherry picked from commit 3135874)
This fix tries to address the inconsistency in moby#22036 where labels set on the command line will not override labels specified in Dockerfile, but will override labels inherited from `FROM` images. The fix add a LABEL with command line options at the end of the processed Dockerfile so that command line options labels always override the LABEL in Dockerfiles (or through `FROM`). An integration test has been added for test cases specified in moby#22036. This fix fixes moby#22036. NOTE: Some changes are from moby#22266 (@tiborvass). Signed-off-by: Yong Tang <yong.tang.github@outlook.com> (cherry picked from commit 5844736)
commit 20a038e changed daemon configuration reloading to check if a value was actually set, however, it checked for the wrong property ("label" instead of "labels"), which resulted in the labels only to be loaded from daemon.json if both a "label" -and- a "labels" property was present. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 455858f)
This fix tries to address the issue in moby#22244 where the remote API `/auth` will not set the default value of `serveraddress` if not provided. This behavior happens after only in 1.11.0 and is a regression as in 1.10.3 `serveraddress` will be assigned with `IndexServer` if no value is provided. The default value `IndexServer` is assigned to `serveraddress` if no value provided in this fix. An integration test `TestAuthApi` has been added to cover this change This fix fixes moby#22244. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> (cherry picked from commit 9397319)
Restore the 1.10 logic that will reset the restart manager's timeout or backoff delay if a container executes longer than 10s reguardless of exit status or policy. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> (cherry picked from commit b6db56b) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
mlaventure
force-pushed
the
1.11.1-cherry-pick
branch
4 times, most recently
from
April 26, 2016 00:54
0ce11be
to
d5a3eeb
Compare
Signed-off-by: Mrunal Patel <mrunalp@gmail.com> Set up the mount label in the spec for a container Signed-off-by: Mrunal Patel <mrunalp@gmail.com> (cherry picked from commit e0f98c6) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
mlaventure
force-pushed
the
1.11.1-cherry-pick
branch
from
April 26, 2016 01:00
d5a3eeb
to
61c0f4b
Compare
win2lin failed due to a network issue:
I'd say good to merge :) |
LGTM |
1 similar comment
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picks for 1.11.1-rc1
PRs Included:
#22318 61c0f4b Update runc and spec dependencies for mount label
#22125 ab1be6f Reset restart timeout if execution longer than 10s
#22254 c06a4c2 Add default
serveraddress
value in remote API/auth
#22299 3b8c11b fix reloading of daemon labels from config
#22184 0c8c9ba Labels set on the command line always override labels in Dockerfile
#22256 dc98419 Use absolute path for rootfs in OCI config.json
#22255 f503494 Bump containerd to v0.2.1
#22253 91880b4 api: server: check for unauthorized error
#22237 75d6341 Fix config cleanup on canceling restartmanager
#22015 2735744 add pkcs11 build tag to deb and rpm builds
#22213 45730a4 Docker http panics caused by container deletion with empty names.
#22172 ce9e2d8 Containerize
TestDaemonNoSpaceLeftOnDeviceError
#22191 c3348d0 Initialize activateWait for plugins activated by json spec
#22123 8c1d802 Remove restart canceled error
#22121 e04dca2 Clean up exec fifos on process exit
#22120 9d68491 Create a copy of stats value before modifications
#22065 ccfb894 Remove deprecation warning
#21993 c941748 Don't throw "restartmanager canceled" error for no restart policy container
#22058 044398a Remove rpc error when shut down daemon
#22048 41130fb docs: update API for features added in 1.11
#21949 9d99e36 Vendor distribution to correct config blob media type in schema2 manifest
This also fixes the content of
VERSION
to be1.11.1