Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.11.1 cherry pick #22242

Merged
merged 22 commits into from
Apr 26, 2016
Merged

1.11.1 cherry pick #22242

merged 22 commits into from
Apr 26, 2016

Conversation

mlaventure
Copy link
Contributor

@mlaventure mlaventure commented Apr 22, 2016

cherry-picks for 1.11.1-rc1

PRs Included:
#22318 61c0f4b Update runc and spec dependencies for mount label
#22125 ab1be6f Reset restart timeout if execution longer than 10s
#22254 c06a4c2 Add default serveraddress value in remote API /auth
#22299 3b8c11b fix reloading of daemon labels from config
#22184 0c8c9ba Labels set on the command line always override labels in Dockerfile
#22256 dc98419 Use absolute path for rootfs in OCI config.json
#22255 f503494 Bump containerd to v0.2.1
#22253 91880b4 api: server: check for unauthorized error
#22237 75d6341 Fix config cleanup on canceling restartmanager
#22015 2735744 add pkcs11 build tag to deb and rpm builds
#22213 45730a4 Docker http panics caused by container deletion with empty names.
#22172 ce9e2d8 Containerize TestDaemonNoSpaceLeftOnDeviceError
#22191 c3348d0 Initialize activateWait for plugins activated by json spec
#22123 8c1d802 Remove restart canceled error
#22121 e04dca2 Clean up exec fifos on process exit
#22120 9d68491 Create a copy of stats value before modifications
#22065 ccfb894 Remove deprecation warning
#21993 c941748 Don't throw "restartmanager canceled" error for no restart policy container
#22058 044398a Remove rpc error when shut down daemon
#22048 41130fb docs: update API for features added in 1.11
#21949 9d99e36 Vendor distribution to correct config blob media type in schema2 manifest

This also fixes the content of VERSION to be 1.11.1

@mlaventure mlaventure force-pushed the 1.11.1-cherry-pick branch 3 times, most recently from 7d286ea to d3e5e42 Compare April 22, 2016 18:23
@mlaventure mlaventure force-pushed the 1.11.1-cherry-pick branch 7 times, most recently from 691f81b to d954e85 Compare April 25, 2016 18:09
@mlaventure
Copy link
Contributor Author

Push what should be the last version.

PTAL and check that I haven't forgotten anything :)

@@ -311,7 +311,7 @@ func getDevicesFromPath(deviceMapping containertypes.DeviceMapping) (devs []spec

// check if it is a symbolic link
if src, e := os.Lstat(deviceMapping.PathOnHost); e == nil && src.Mode()&os.ModeSymlink == os.ModeSymlink {
if linkedPathOnHost, e := os.Readlink(deviceMapping.PathOnHost); e == nil {
if linkedPathOnHost, e := filepath.EvalSymlinks(deviceMapping.PathOnHost); e == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixing a P3, it has nothing to do in a patch release.

@mlaventure mlaventure force-pushed the 1.11.1-cherry-pick branch 2 times, most recently from 2160b2f to f8ec19b Compare April 25, 2016 22:08
mlaventure and others added 14 commits April 25, 2016 15:10
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
…fest

@nwt noticed that the media type specified in the config section of a
schema2 manifest is application/octet-stream, instead of the correct
value application/vnd.docker.container.image.v1+json.

This brings in distribution/distribution#1622 to fix
this.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
(cherry picked from commit c18d03a)
Docker 1.11 added a feature to set labels on volumes,
networks and images (during build), but these changes
were not documented in the API documentation.

This adds the new features to the documentation.

Also fixes some minor formatting, and options that
were not used in the examples.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit ba353f3)
RPC connection closing error will be reported every time we shutdown
daemon, this error is expected, so we should remove this error to avoid
confusion to user.

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
(cherry picked from commit a02ae66)
…tainer

Don't throw "restartmanager canceled" error for no restart policy container
and add the container id to the warning message if a container has restart policy
and has been canceled.

Signed-off-by: Lei Jitang <leijitang@huawei.com>
(cherry picked from commit 494297b)
Auto-creation of non-existing host directories
is no longer deprecated (9d5c26b),
so this warning is no longer relevant.

This removes the deprecation warning.

Also removes the "system" package here, because it's only used
on non-Windows, so basically just called os.MkdirAll()

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 1d02ad2)
Fixes moby#22030

Because the publisher uses this same value to all the
stats endpoints we need to make a copy of this as soon as we get it so
that we can make our modifications without it affecting others.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
(cherry picked from commit d17ee4b)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 84d1701)
It should not be an error to call a common option to cancel restarts.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
(cherry picked from commit fc2e223)
Signed-off-by: Madhu Venugopal <madhu@docker.com>
(cherry picked from commit de806a6)
Why? Because the `mount` here will sometimes fail when run in
`debian:jessie`, which is what the environrment hosting the test suite
is running if run from the `Makefile`.
Also, why the heck not containerize it, all the things.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 59b83d8)
This fix tries to fix the http panics caused by container deletion
with empty names in moby#22210.

The issue was because when an empty string was passed, `GetByName()`
tried to access the first element of the name string without checking
the length. A length check has been added.

A test case for moby#22210 has been added.

This fix fixes moby#22210.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit 9d8071a)
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)

(cherry picked from commit 829d188)
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 7bf0773)
runcom and others added 7 commits April 25, 2016 15:10
This functionality has been fixed by
7bca932 but then it has been broken
again by a793564 and finally refixed
here.

Basically the functionality was to prompt for login when trying to pull
from the official docker hub.

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
(cherry picked from commit 4316ae2)
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
(cherry picked from commit 199472c)
This avoid an extra bind mount within /var/run/docker/libcontainerd

This should resolve situations where a container having the host
/var/run bound prevents other containers from being cleanly removed
(e.g. moby#21969).

Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
(cherry picked from commit 3135874)
This fix tries to address the inconsistency in moby#22036 where labels
set on the command line will not override labels specified in
Dockerfile, but will override labels inherited from `FROM` images.

The fix add a LABEL with command line options at the end of the
processed Dockerfile so that command line options labels always
override the LABEL in Dockerfiles (or through `FROM`).

An integration test has been added for test cases specified in moby#22036.

This fix fixes moby#22036.

NOTE: Some changes are from moby#22266 (@tiborvass).

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit 5844736)
commit 20a038e changed
daemon configuration reloading to check if a value
was actually set, however, it checked for the wrong
property ("label" instead of "labels"), which resulted
in the labels only to be loaded from daemon.json if both
a "label" -and- a "labels" property was present.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 455858f)
This fix tries to address the issue in moby#22244 where the remote
API `/auth` will not set the default value of `serveraddress`
if not provided. This behavior happens after only in 1.11.0
and is a regression as in 1.10.3 `serveraddress` will be assigned
with `IndexServer` if no value is provided.

The default value `IndexServer` is assigned to `serveraddress` if
no value provided in this fix.

An integration test `TestAuthApi` has been added to cover this change

This fix fixes moby#22244.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit 9397319)
Restore the 1.10 logic that will reset the restart manager's timeout or
backoff delay if a container executes longer than 10s reguardless of
exit status or policy.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
(cherry picked from commit b6db56b)
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
@mlaventure mlaventure force-pushed the 1.11.1-cherry-pick branch 4 times, most recently from 0ce11be to d5a3eeb Compare April 26, 2016 00:54
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>

Set up the mount label in the spec for a container

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
(cherry picked from commit e0f98c6)
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
@mlaventure
Copy link
Contributor Author

win2lin failed due to a network issue:

01:56:36 ----------------------------------------------------------------------
01:56:36 FAIL: docker_cli_build_test.go:2911: DockerSuite.TestBuildAddRemoteFileMTime
01:56:36 
01:56:36 docker_cli_build_test.go:2966:
01:56:36     c.Fatal(err)
01:56:36 ... Error: failed to build the image: Sending build context to Docker daemon 2.048 kB

01:56:36 Step 1 : FROM scratch
01:56:36  ---> 
01:56:36 Step 2 : MAINTAINER dockerio
01:56:36  ---> Using cache
01:56:36  ---> 4e15856e030a
01:56:36 Step 3 : ADD http://10.0.0.12:32771/baz /usr/lib/baz/quux
01:56:36 Get http://10.0.0.12:32771/baz: dial tcp 10.0.0.12:32771: getsockopt: connection refused
01:56:36 
01:56:36 
01:56:39 
01:56:39 ----------------------------------------------------------------------

I'd say good to merge :)

@tonistiigi
Copy link
Member

LGTM

1 similar comment
@tiborvass
Copy link
Contributor

LGTM

@tiborvass tiborvass merged commit 7ef1cfd into moby:bump_v1.11.1 Apr 26, 2016
@mlaventure mlaventure deleted the 1.11.1-cherry-pick branch May 6, 2016 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.