Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated 'with' from project init scaffold and small bug fix #653

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Removed deprecated 'with' from project init scaffold and small bug fix #653

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0025ec
Removed deprecated 'with' from project init scaffold and added 'firef…
jrrom Sep 12, 2023
974573f
Removed 'chromium-bin' as it is deprecated
jrrom Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removed deprecated 'with' from project init scaffold and added 'firef… 
…ox-bin' and 'chromium-bin' to BROWSER_PATHS
  • Loading branch information
@jrrom
jrrom committed Sep 12, 2023
commit f0025eccc09f6340684a31488ec447f041844c8c
8 changes: 3 additions & 5 deletions src/app_init/app/tests/Main.mint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
suite "Main" {
test "Greets Mint" {
with Test.Html {
<Main/>
|> start()
|> assertTextOf("a", "Learn Mint")
}
<Main/>
|> Test.Html.start()
|> Test.Html.assertTextOf("a", "Learn Mint")
}
}
2 changes: 2 additions & 0 deletions src/test_runner.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@ module Mint
BROWSER_PATHS = {
firefox: {
"firefox",
"firefox-bin",
"/Applications/Firefox.app/Contents/MacOS/firefox-bin",
},
chrome: {
"chromium-browser",
"chromium",
"chromium-bin",
"google-chrome",
"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome",
},
Expand Down