Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HTTP module a bit. #588

Merged
merged 3 commits into from
May 1, 2023
Merged

Refactor HTTP module a bit. #588

merged 3 commits into from
May 1, 2023

Conversation

gdotdesign
Copy link
Member

  • Added response headers to Http.Response and Http.ErrorResponse
  • Removed Http.sendWithId
  • The second parameter of Http.send now has a default value
  • The body of the response is now an enum and supports binary values

Should fix #494

@gdotdesign
Refactor HTTP module a bit.
c75ccd6 
- Added response headers to `Http.Response` and `Http.ErrorResponse`
- Removed `Http.sendWithId`
- The second parameter of `Http.send` now has a default value
- The body of the response is now an enum and supports binary values
@gdotdesign gdotdesign added feature request stdlib Standard library related labels Apr 26, 2023
@gdotdesign gdotdesign added this to the 0.18.0 milestone Apr 26, 2023
@gdotdesign gdotdesign requested a review from Sija April 26, 2023 15:24
@gdotdesign gdotdesign self-assigned this Apr 26, 2023
@gdotdesign gdotdesign linked an issue Apr 26, 2023 that may be closed by this pull request
Access to Http response headers #494
Closed
Sija
Sija reviewed Apr 26, 2023
View reviewed changes
core/source/Http.mint Outdated Show resolved Hide resolved
core/source/Http.mint Outdated Show resolved Hide resolved
core/source/Http.mint Outdated Show resolved Hide resolved
@gdotdesign gdotdesign requested a review from Sija April 27, 2023 14:05
Sija
Sija reviewed Apr 27, 2023
View reviewed changes
core/source/Http.mint Outdated Show resolved Hide resolved
@gdotdesign @Sija
Update core/source/Http.mint
9138b3d 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
@gdotdesign gdotdesign merged commit 9f19e36 into master May 1, 2023
@gdotdesign gdotdesign deleted the 494-access-to-http-response-headers branch May 1, 2023 10:00
nilslindemann added a commit to nilslindemann/mint-tutorial that referenced this pull request May 17, 2023
@nilslindemann
Use response.bodyString
ae8ff09 
mint-lang/mint#588 changed the structure of the Http.Response record. This commit adapts to these changes.
@nilslindemann nilslindemann mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija approved these changes

Assignees

@gdotdesign gdotdesign

Labels
feature request stdlib Standard library related
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

Access to Http response headers
2 participants
@gdotdesign @Sija