Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Several Broken Integration Tests #10372

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fixed Several Broken Integration Tests #10372

merged 2 commits into from
Jan 17, 2025

Conversation

MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented Jan 15, 2025 •
edited
Loading

Description

In addition to the issue addressed here, this PR fixes several other broken integration tests that are causing our deployments to fail.

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa MinuraPunchihewa changed the title Fixed the Status Codes for the HTTP Tests Fixed Several Integration Tests Jan 15, 2025
@MinuraPunchihewa MinuraPunchihewa changed the title Fixed Several Integration Tests Fixed Several Broken Integration Tests Jan 15, 2025
@MinuraPunchihewa MinuraPunchihewa marked this pull request as ready for review January 15, 2025 18:53
hamishfagg
hamishfagg approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@hamishfagg hamishfagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for this!

@MinuraPunchihewa MinuraPunchihewa merged commit 068bbdd into main Jan 17, 2025
16 checks passed
@MinuraPunchihewa MinuraPunchihewa deleted the bugfix/fix_http_tests branch January 17, 2025 11:49
@mindsdb mindsdb locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StpMax StpMax StpMax approved these changes

@hamishfagg hamishfagg hamishfagg approved these changes

Assignees
No one assigned
Labels
deploy-to-dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinuraPunchihewa @hamishfagg @StpMax