Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Reserved Keywords to SqlalchemyRender #10361

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Added Reserved Keywords to SqlalchemyRender #10361

merged 6 commits into from
Jan 15, 2025

Conversation

MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented Jan 14, 2025 •
edited
Loading

Description

This PR checks for unregistered keywords in SqlalchemyRender. This fixes the failing integration tests.

Fixes https://linear.app/mindsdb/issue/BE-607/investigate-and-fix-failing-integration-tests

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa MinuraPunchihewa marked this pull request as ready for review January 14, 2025 13:47
@MinuraPunchihewa
Copy link
Contributor Author

@ea-rus I tried if part.lower() != part_lower and part not in RESERVED_WORDS: but that does not seem to work since part is already assigned prior to this.

@MinuraPunchihewa MinuraPunchihewa changed the title Added reserved Keywords to SqlalchemyRender Added Reserved Keywords to SqlalchemyRender Jan 14, 2025
@MinuraPunchihewa MinuraPunchihewa merged commit f55d76f into main Jan 15, 2025
14 checks passed
@MinuraPunchihewa MinuraPunchihewa deleted the bugfix/add_reserved_keywords branch January 15, 2025 10:10
@mindsdb mindsdb locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ea-rus ea-rus ea-rus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MinuraPunchihewa @ea-rus