Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Documentation for Docker by Omitting the Exposure of the MySQL API's Port #10360

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

MinuraPunchihewa
Copy link
Contributor

Description

This PR updates the documentation for running MindsDB via Docker by omitting the exposure of the MySQL API's port because as mentioned in the issue below, by default, only the HTTP API is started.

A tip for running the other APIs using the MINDSDB_APIS environment variable has also been added.

Fixes https://linear.app/mindsdb/issue/BE-612/update-the-documentation-for-docker-by-removing-exposure-of-the-mysql

Type of change

  • 📄 This is a documentation update

The use of the MINDSDB_APIS environment variable depends on #10354

- `mindsdb/mindsdb` is a Docker image provided by MindsDB. You can choose a different one from the list above.

<Tip>
By default, MindsDB starts only the `http` API. You can define which APIs to start by passing the `MINDSDB_APIS` environment variable with a comma-separated list when running the container as shown below. To expose the ports for the APIs, you need to add the respective ports to the command with the `-p` flag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Minura. This looks good. A couple of small things:

Let's change
`http` API
to
HTTP API
like it is above.

Also, please let's add a link to the environment variables doc page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@MinuraPunchihewa MinuraPunchihewa merged commit 6818bb8 into main Jan 14, 2025
13 checks passed
@MinuraPunchihewa MinuraPunchihewa deleted the docs/remove_mysql_api_docker branch January 14, 2025 13:22
@mindsdb mindsdb locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants