Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Fallback Retriever if SQL Retriever Doesn't Retrieve Documents #10349

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Use Fallback Retriever if SQL Retriever Doesn't Retrieve Documents #10349

merged 1 commit into from
Jan 10, 2025
+6 −2

Conversation

tmichaeldb
Copy link
Contributor

Description

If SQL retriever constructs a query that returns no documents, we should fallback to our base retriever.

Fixes ML-240

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

fshabashev
fshabashev approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@fshabashev fshabashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichaeldb tmichaeldb merged commit d197b26 into main Jan 10, 2025
15 checks passed
@tmichaeldb tmichaeldb deleted the sql-retriever-improvements branch January 10, 2025 20:06
@mindsdb mindsdb locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fshabashev fshabashev fshabashev approved these changes

@lucas-koontz lucas-koontz Awaiting requested review from lucas-koontz

@dusvyat dusvyat Awaiting requested review from dusvyat

@QuantumPlumber QuantumPlumber Awaiting requested review from QuantumPlumber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmichaeldb @fshabashev