Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] upgrade fastapi and uvicorn and configure actions #985

Closed
wants to merge 11 commits into from

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Jul 12, 2022

This PR:

  • upgrades fastapi and uvicorn to latest version
  • add delay (for model loading) and move docs ping at the end

Any feedback is welcome 🤗

Issue:
#847

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #985 (6eb5d3f) into main (1dafd33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         134      134           
  Lines        5556     5556           
=======================================
  Hits         5272     5272           
  Misses        284      284           
Flag Coverage Δ
unittests 94.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dafd33...6eb5d3f. Read the comment docs.

@felixdittrich92 felixdittrich92 changed the title update fastapi version specifier update fastapi version specifier [wont fix] Jul 13, 2022
@felixdittrich92
Copy link
Contributor Author

I have no problems that's really a bit weird 😅

(work) felix@felix-GS66-Stealth-11UH:~/Desktop/doctr$ curl -I http://localhost:8002/docs
HTTP/1.1 200 OK
date: Wed, 13 Jul 2022 12:17:07 GMT
server: uvicorn
content-length: 942
content-type: text/html; charset=utf-8
x-process-time: 0.0002713203430175781

@felixdittrich92 felixdittrich92 changed the title update fastapi version specifier [wont fix] [api] upgrade fastapi and uvicorn and configure actions Jul 13, 2022
@felixdittrich92 felixdittrich92 added type: bug Something isn't working topic: ci Related to CI topic: docker Docker-related ext: api Related to api folder labels Jul 13, 2022
@felixdittrich92 felixdittrich92 added this to the 0.5.2 milestone Jul 13, 2022
@felixdittrich92 felixdittrich92 self-assigned this Jul 13, 2022
@felixdittrich92 felixdittrich92 linked an issue Jul 13, 2022 that may be closed by this pull request
@felixdittrich92 felixdittrich92 marked this pull request as ready for review July 13, 2022 12:45
@felixdittrich92 felixdittrich92 mentioned this pull request Jul 13, 2022
14 tasks
@frgfm
Copy link
Collaborator

frgfm commented Jul 13, 2022

I'll have to run tests more specifically : the fact that the tests succeeded this time seems to indicate that there are some conflicts in the loose version range that we allowed earlier

I solved similar problems recently on another project, I'll check this. But the message here is: I think this PR is not solving the previous issue :/

@felixdittrich92 felixdittrich92 marked this pull request as draft July 13, 2022 13:55
@felixdittrich92
Copy link
Contributor Author

Lets see i think the main problem was/ is, that there is a minor delay before docs are available

@felixdittrich92
Copy link
Contributor Author

felixdittrich92 commented Jul 13, 2022

@frgfm with old versions it passes also 😅 Also locally i was not able to reproduce this issue

But if you would like to take a look at it again, it wouldn't be wrong 👍

@felixdittrich92
Copy link
Contributor Author

Closed with #997

@felixdittrich92 felixdittrich92 deleted the upgrade-fastapi branch July 26, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder topic: ci Related to CI topic: docker Docker-related type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doctr api doc error on docker
2 participants