-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactoring rotated boxes #731
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
aa4e253
refacto: rboxes
charlesmindee dc95b33
feat: builder modifications
charlesmindee 3b3418f
fix: rotate_abs_boxes
charlesmindee d940277
refacto: viz + metrics
charlesmindee 5090582
fix: merging issues
charlesmindee 29d9d53
fix: flake8 + typing
charlesmindee 17c8572
Merge branch 'main' into refacto_polys
charlesmindee 2903f02
fix: debug 1
charlesmindee 35332e6
fix: debug 2 tests
charlesmindee e0e32c7
fix: debug test 3
charlesmindee 2876eb9
fix: requested changes
charlesmindee 6a70b70
Merge branch 'main' into refacto_polys
charlesmindee adb95bf
fix: test rotate
charlesmindee 183ce86
fix: debug 4
charlesmindee a934869
fix: cv2 tests metrics
charlesmindee a1b76b5
fix: revert changes
charlesmindee ad593d2
fix: isort
charlesmindee 3db928f
fix: thresh for rotated ckpt
charlesmindee b388bf5
fix: utils + scripts
charlesmindee 6ae8240
fix: warnings
charlesmindee cef1931
fix: tests
charlesmindee 8772c63
Merge branch 'main' into refacto_polys
charlesmindee 2e29f9f
fix: tf zoo tests
charlesmindee badbb6a
Merge branch 'main' into refacto_polys
charlesmindee 213ac99
fix: requested changes 1
charlesmindee 5f38ab4
fix: tests
charlesmindee 6877601
fix: tests
charlesmindee 3552a97
fix: scripts
charlesmindee bbf689d
fix: dataset stack
charlesmindee 445f9d4
fix: typing
charlesmindee 6bd4c59
fix: test zoo tf
charlesmindee 17f1758
fix: builder
charlesmindee a6f01c8
fix: merging conflicts
charlesmindee 4f99940
fix: tests merging conflicts
charlesmindee 219661f
fix: minor changes
charlesmindee 715040a
fix: crop extraction fn
charlesmindee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: debug 4
- Loading branch information
commit 183ce86c9c0517210eff0453643cc0db3b9a7fe4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but since it's a predictor, let's ensure we are in eval mode:
could you add
.eval()
at the end of the line please?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still missing the
.eval()
, let's make sure we have all models in eval mode in a predictor