feat: ✨ tqdm slack #1837
Merged
feat: ✨ tqdm slack #1837
+90
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1837 +/- ##
==========================================
- Coverage 96.59% 96.56% -0.04%
==========================================
Files 165 165
Lines 7940 7940
==========================================
- Hits 7670 7667 -3
- Misses 270 273 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felixdittrich92
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks @odulcy-mindee 🤗
Could we add a quick note to each README in the references how to setup (maybe slack reference link) and that both values needs to be set as env ?
felixdittrich92
added
topic: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of
tqdm slackis explained here. You only need to set environment variables, no need to pass token and channel in args.