Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in unpacking archive of SROIE dataset #1178

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Error in unpacking archive of SROIE dataset #1178

merged 3 commits into from
Apr 20, 2023

Conversation

HamzaGbada
Copy link
Contributor

Fixing the unpacking archive of SROIE dataset.

@felixdittrich92 felixdittrich92 self-assigned this Apr 19, 2023
@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: datasets Related to doctr.datasets labels Apr 19, 2023
@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone Apr 19, 2023
@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Apr 19, 2023 •
edited
Loading

Test:

doctr/tests/pytorch/test_datasets_pt.py

Line 272 in 51c4237

datasets.SROIE.TRAIN = (mock_sroie_dataset, None)

needs also an update:

(mock_sroie_dataset, None, "sroie2019_train_task1.zip")

Same for the Tensorflow test case :)

doctr/tests/tensorflow/test_datasets_tf.py

Line 246 in 51c4237

datasets.SROIE.TRAIN = (mock_sroie_dataset, None)

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #1178 (d5d0df0) into main (51c4237) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1178   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         150      150           
  Lines        6418     6418           
=======================================
  Hits         6098     6098           
  Misses        320      320
Flag Coverage Δ
unittests 95.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/sroie.py 97.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

felixdittrich92
felixdittrich92 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @HamzaGbada 👍

@felixdittrich92 felixdittrich92 merged commit d712b94 into mindee:main Apr 20, 2023
@felixdittrich92
Copy link
Contributor

Hey @HamzaGbada 👋,

i saw that we have the same issue for CORD dataset are you interessted to fix this also maybe ?
Same changes would be required like in this PR :)

@felixdittrich92 felixdittrich92 mentioned this pull request Apr 30, 2023
Closed
@HamzaGbada
Copy link
Contributor Author

Hey @HamzaGbada wave,

i saw that we have the same issue for CORD dataset are you interessted to fix this also maybe ? Same changes would be required like in this PR :)

@felixdittrich92 SURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdittrich92 felixdittrich92 felixdittrich92 approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
module: datasets Related to doctr.datasets type: bug Something isn't working
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HamzaGbada @felixdittrich92