Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [skip e2e]update webui logic #38755

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix: [skip e2e]update webui logic #38755

merged 1 commit into from
Dec 31, 2024

Conversation

mimoning
Copy link
Contributor

issue: #36621

  • update collection detail page logic
  • fix data page segments list
  • remove useless js file

@mimoning mimoning changed the title fix: update webui logic fix: [skip e2e]update webui logic Dec 25, 2024
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 25, 2024
@mimoning mimoning mentioned this pull request Dec 25, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@mimoning Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels Dec 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@mimoning cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (c7ea09a) to head (2d82a2a).
Report is 32 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38755       +/-   ##
===========================================
+ Coverage   69.32%   81.12%   +11.80%     
===========================================
  Files         292     1385     +1093     
  Lines       26182   196059   +169877     
===========================================
+ Hits        18150   159057   +140907     
- Misses       8032    31408    +23376     
- Partials        0     5594     +5594
Components Coverage Δ
Client 79.12% <ø> (∅)
Core 69.45% <44.44%> (+0.13%) ⬆️
Go 83.09% <ø> (∅)

see 1108 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@mimoning go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 31, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mimoning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit accfacf into milvus-io:master Dec 31, 2024
18 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 31, 2024
@mimoning
fix: [2.5][skip e2e]update webui logic (#38754)
e389ae2 
issue: #36621
pr: #38755

* update collection detail page logic
* fix data page segments list
* remove useless js file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xige-16 xige-16 Awaiting requested review from xige-16

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@jaime0815 jaime0815

Labels
approved ci-passed kind/bug Issues or changes related a bug lgtm needs-dco DCO is missing in this pull request. size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mimoning @sre-ci-robot @jaime0815