Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [2.5][skip e2e]update webui logic #38754

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from
Open

fix: [2.5][skip e2e]update webui logic #38754

wants to merge 1 commit into from
+61 −1,555

Conversation

mimoning
Copy link
Contributor

@mimoning mimoning commented Dec 25, 2024 •
edited
Loading

issue: #36621
pr: #38755

  • update collection detail page logic
  • fix data page segments list
  • remove useless js file

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mimoning
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@mimoning Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Dec 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@mimoning Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Dec 25, 2024
@mimoning mimoning changed the title fix: [skip e2e]update webui logic fix: [2.5][skip e2e]update webui logic Dec 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@mimoning go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@mimoning E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (d47372e) to head (9d3b3bb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38754       +/-   ##
===========================================
+ Coverage   69.34%   81.03%   +11.69%     
===========================================
  Files         292     1381     +1089     
  Lines       26191   195158   +168967     
===========================================
+ Hits        18161   158138   +139977     
- Misses       8030    31450    +23420     
- Partials        0     5570     +5570
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.34% <ø> (ø)
Go 83.01% <ø> (∅)

see 1089 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees
No one assigned
Labels
ci-passed kind/bug Issues or changes related a bug needs-dco DCO is missing in this pull request. size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimoning @sre-ci-robot