Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: remove extra memory copy of bf16/bf16 brustforce search #38751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: remove extra memory copy of bf16/bf16 brustforce search #38751

wants to merge 1 commit into from
+6 −24

Conversation

cqy123456
Copy link
Contributor

issue: #37798
related knowhere pr: zilliztech/knowhere#980

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 25, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (85f462b) to head (684b46e).
Report is 1 commits behind head on master.

❗ Current head 684b46e differs from pull request most recent head a99acb6

Please upload reports for the commit a99acb6 to get more accurate results.

Files with missing lines Patch % Lines
internal/core/src/query/SearchBruteForce.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38751      +/-   ##
==========================================
- Coverage   81.12%   81.09%   -0.04%     
==========================================
  Files        1383     1381       -2     
  Lines      195605   195248     -357     
==========================================
- Hits       158689   158337     -352     
- Misses      31320    31330      +10     
+ Partials     5596     5581      -15
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.31% <66.66%> (-0.13%) ⬇️
Go 83.09% <ø> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/query/SearchBruteForce.cpp 79.06% <66.66%> (-0.66%) ⬇️

... and 60 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 25, 2024
@mergify mergify bot removed the ci-passed label Dec 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@cqy123456
enhance: remove extra memory copy of bf16/bf16 brustforce search
a99acb6 
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cqy123456 @sre-ci-robot