Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Remove sync task after finished (#38681) #38686

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Dec 24, 2024

Cherry-pick from master
pr: #38681
Related to #38680

Related to milvus-io#38680

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Dec 24, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 24, 2024
Copy link
Contributor

mergify bot commented Dec 24, 2024

@congqixia Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5fd69a0 into milvus-io:2.4 Dec 24, 2024
13 checks passed
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.38%. Comparing base (7363a1c) to head (bac3d62).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38686      +/-   ##
==========================================
- Coverage   80.38%   80.38%   -0.01%     
==========================================
  Files        1077     1077              
  Lines      169449   169453       +4     
==========================================
- Hits       136219   136214       -5     
- Misses      28748    28766      +18     
+ Partials     4482     4473       -9     
Files with missing lines Coverage Δ
internal/datanode/syncmgr/sync_manager.go 80.72% <100.00%> (+0.97%) ⬆️

... and 32 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants