Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interted index out of range #38577

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 19, 2024

issue: #38546, #38486

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 19, 2024
@chyezh chyezh added this to the 2.5.0 milestone Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 19, 2024
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fix_inverted_index_out_of_range branch from 9de1de1 to 288af9d Compare December 19, 2024 04:08
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (01cfb1f) to head (288af9d).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38577      +/-   ##
==========================================
- Coverage   81.00%   80.99%   -0.02%     
==========================================
  Files        1379     1379              
  Lines      194397   194402       +5     
==========================================
- Hits       157475   157454      -21     
- Misses      31358    31396      +38     
+ Partials     5564     5552      -12     
Components Coverage Δ
Client 75.88% <ø> (ø)
Core 69.33% <100.00%> (+<0.01%) ⬆️
Go 83.02% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexUtil.h 73.68% <100.00%> (+12.14%) ⬆️
internal/core/src/index/TextMatchIndex.cpp 40.64% <100.00%> (-0.39%) ⬇️

... and 42 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 19, 2024
@@ -246,12 +246,12 @@ TextMatchIndex::MatchQuery(const std::string& query) {
Reload();
}

auto cnt = wrapper_->count();
auto hits = wrapper_->match_query(query);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz leave a comment here

@czs007
Copy link
Collaborator

czs007 commented Dec 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b537a72 into milvus-io:master Dec 19, 2024
19 of 20 checks passed
@chyezh chyezh deleted the fix_inverted_index_out_of_range branch December 19, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants