Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Bump milvus & proto version to v2.4.18 #38552

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Dec 18, 2024

mockery update related to #31779

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Dec 18, 2024
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Dec 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 18, 2024
Copy link
Contributor

mergify bot commented Dec 18, 2024

@congqixia Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (2e2f615) to head (69e9825).
Report is 9 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38552       +/-   ##
===========================================
+ Coverage   72.18%   83.41%   +11.23%     
===========================================
  Files        1077      809      -268     
  Lines      169355   142904    -26451     
===========================================
- Hits       122248   119207     -3041     
+ Misses      42651    19234    -23417     
- Partials     4456     4463        +7     
Files with missing lines Coverage Δ
pkg/common/version.go 100.00% <100.00%> (ø)

... and 299 files with indirect coverage changes

@yanliang567 yanliang567 added this to the 2.4.18 milestone Dec 18, 2024
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [congqixia,yanliang567]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 451deb3 into milvus-io:2.4 Dec 19, 2024
15 checks passed
@congqixia congqixia deleted the bump/v2.4.18 branch December 23, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants