Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: clean compaction task in compactionHandler #38170

Merged
merged 4 commits into from
Dec 19, 2024
Merged

enhance: clean compaction task in compactionHandler #38170

merged 4 commits into from
Dec 19, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #35711

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 3, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 48 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (de88589) to head (9392be1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/compaction_task_clustering.go 77.58% 20 Missing and 6 partials ⚠️
internal/datacoord/compaction_task_mix.go 35.00% 13 Missing ⚠️
internal/datacoord/partition_stats_meta.go 72.72% 4 Missing and 2 partials ⚠️
pkg/util/merr/utils.go 50.00% 2 Missing ⚠️
internal/datacoord/compaction_task_l0.go 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38170      +/-   ##
==========================================
- Coverage   81.00%   80.98%   -0.03%     
==========================================
  Files        1379     1378       -1     
  Lines      194455   194350     -105     
==========================================
- Hits       157515   157388     -127     
- Misses      31395    31398       +3     
- Partials     5545     5564      +19
Components Coverage Δ
Client 75.27% <ø> (ø)
Core 69.32% <ø> (ø)
Go 83.02% <76.92%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 71.37% <100.00%> (+1.63%) ⬆️
internal/datacoord/compaction_task.go 100.00% <ø> (ø)
internal/datacoord/meta.go 89.67% <100.00%> (+0.03%) ⬆️
pkg/util/merr/errors.go 92.18% <ø> (ø)
internal/datacoord/compaction_task_l0.go 92.85% <88.88%> (-1.07%) ⬇️
pkg/util/merr/utils.go 84.26% <50.00%> (+0.61%) ⬆️
internal/datacoord/partition_stats_meta.go 54.85% <72.72%> (+7.68%) ⬆️
internal/datacoord/compaction_task_mix.go 66.40% <35.00%> (+3.80%) ⬆️
internal/datacoord/compaction_task_clustering.go 78.96% <77.58%> (+1.26%) ⬆️

... and 59 files with indirect coverage changes

@xiaocai2333 xiaocai2333 force-pushed the fix_34991 branch 2 times, most recently from 1ee73a2 to f02b05d Compare December 3, 2024 07:26
@mergify mergify bot added the ci-passed label Dec 3, 2024
@czs007 czs007 added this to the 2.5.0 milestone Dec 4, 2024
@xiaocai2333 xiaocai2333 mentioned this pull request Dec 17, 2024
Open
1 task
@mergify mergify bot removed the ci-passed label Dec 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

wayblink and others added 2 commits December 18, 2024 20:22
@wayblink @xiaocai2333
enhance: clean failed/timeout compaction task in compactionHandler
65089e5 
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@xiaocai2333
update
5495ec1 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify mergify bot added the ci-passed label Dec 18, 2024
@xiaocai2333
refine
5ef3d12 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify mergify bot removed the ci-passed label Dec 19, 2024
@xiaocai2333
refine
9392be1 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Dec 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 19, 2024
@sre-ci-robot sre-ci-robot merged commit 306e5e6 into milvus-io:master Dec 19, 2024
18 of 20 checks passed
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request Dec 19, 2024
@xiaocai2333 @wayblink
enhance: clean compaction task in compactionHandler (milvus-io#38170)
62b22e1 
issue: milvus-io#35711

---------

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
@xiaocai2333 xiaocai2333 mentioned this pull request Dec 19, 2024
Merged
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request Dec 19, 2024
@xiaocai2333 @wayblink
enhance: clean compaction task in compactionHandler (milvus-io#38170)
76c0d41 
issue: milvus-io#35711

---------

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Dec 24, 2024
@xiaocai2333 @wayblink
enhance: [2.4] clean compaction task in compactionHandler (#38170) (#…
afaabc2 
…38584)

issue: #35711

master pr: #38170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
xiaocai2333 added a commit to xiaocai2333/milvus that referenced this pull request Dec 25, 2024
@xiaocai2333
Revert "enhance: [2.4] clean compaction task in compactionHandler (mi…
f7ba5f7 
…lvus-io#38170) (#…"

This reverts commit afaabc2.
@xiaocai2333 xiaocai2333 mentioned this pull request Dec 25, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Dec 25, 2024
@xiaocai2333
enhance: [2.4] Revert clean compaction task in compactionHandler (#38753
e8eea58 
)

Reverts #38584

issue: #35711

master pr: #38170

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaocai2333 @czs007 @sre-ci-robot @wayblink