Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Handoff growing segment after sorted #37385

Merged
merged 1 commit into from
Nov 7, 2024
Merged

enhance: Handoff growing segment after sorted #37385

merged 1 commit into from
Nov 7, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #33744

  1. Segments generated from inserts will be loaded as growing until they are sorted by primary key.
  2. This PR may increase memory pressure on the delegator, but we need to test the performance of stats. In local testing, the speed of stats is greater than the insert speed.

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby November 2, 2024 08:41
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 2, 2024
@xiaocai2333 xiaocai2333 mentioned this pull request Nov 2, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (f813fb4) to head (3ba16c2).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37385   +/-   ##
=======================================
  Coverage   67.31%   67.31%           
=======================================
  Files         290      290           
  Lines       25377    25377           
=======================================
  Hits        17082    17082           
  Misses       8295     8295
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.31% <ø> (ø)
Go ∅ <ø> (∅)

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the handoff_growing_after_stats branch from 5f9fbd0 to cbc1f38 Compare November 4, 2024 03:51
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the handoff_growing_after_stats branch from cbc1f38 to 0955e28 Compare November 4, 2024 12:11
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the handoff_growing_after_stats branch from 0955e28 to d4b328d Compare November 5, 2024 06:39
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the handoff_growing_after_stats branch from d4b328d to 1ce98ea Compare November 6, 2024 09:00
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

@xiaocai2333 please rebase mater to resolve the integration test failure.

@xiaocai2333
Handoff growing segment after sorted
3ba16c2 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 force-pushed the handoff_growing_after_stats branch from 1ce98ea to 3ba16c2 Compare November 7, 2024 02:53
@mergify mergify bot added the ci-passed label Nov 7, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4dc6841 into milvus-io:master Nov 7, 2024
14 of 15 checks passed
@xiaocai2333 xiaocai2333 deleted the handoff_growing_after_stats branch November 8, 2024 03:12
@xiaocai2333 xiaocai2333 mentioned this pull request Nov 12, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@sunby sunby Awaiting requested review from sunby

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot