Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add an unify vector index config checker #36844

Merged
merged 1 commit into from
Oct 28, 2024
Merged

enhance: add an unify vector index config checker #36844

merged 1 commit into from
Oct 28, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Oct 14, 2024 •
edited
Loading

issue: #34298

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation area/test sig/testing test/integration integration test labels Oct 14, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Oct 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

@foxspy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@foxspy foxspy mentioned this pull request Oct 14, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_config_checker branch 2 times, most recently from dd49a84 to 09c7bb6 Compare October 15, 2024 05:37
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 15, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_config_checker branch from 09c7bb6 to 1b430c8 Compare October 15, 2024 05:47
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 15, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_config_checker branch from 1b430c8 to f6165cf Compare October 15, 2024 10:14
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 15, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 15, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_config_checker branch from f6165cf to 093dd79 Compare October 16, 2024 03:34
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_config_checker branch from 093dd79 to 9237b52 Compare October 16, 2024 05:18
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 16, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_config_checker branch from 9237b52 to 6dafa3c Compare October 16, 2024 08:48
@foxspy foxspy mentioned this pull request Oct 16, 2024
Merged
@foxspy foxspy force-pushed the remove_vector_index_config_checker branch 2 times, most recently from b684425 to d96b9c5 Compare October 17, 2024 02:25
@alexanderguzhva alexanderguzhva mentioned this pull request Oct 21, 2024
Closed
@foxspy foxspy force-pushed the remove_vector_index_config_checker branch from 49d96c4 to 324f5e6 Compare October 23, 2024 07:32
@mergify mergify bot removed the ci-passed label Oct 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Oct 23, 2024

/run-cpu-e2e

2 similar comments
@foxspy
Copy link
Contributor Author

foxspy commented Oct 23, 2024

/run-cpu-e2e

@foxspy
Copy link
Contributor Author

foxspy commented Oct 23, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_config_checker branch from 324f5e6 to 9515e36 Compare October 23, 2024 12:07
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Oct 23, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@liliu-z
Copy link
Member

liliu-z commented Oct 24, 2024

@foxspy
[pytest : test] [2024-10-23 16:48:58 - ERROR - pymilvus.decorators]: RPC error: [create_index], <MilvusException: (code=1100, message=metric type not found or not supported, supported: [IP]: invalid parameter[expected=valid index params][actual=invalid index params])>, <Time:{'RPC start': '2024-10-23 16:48:58.544908', 'RPC error': '2024-10-23 16:48:58.547414'}> (decorators.py:140)

@foxspy
add unify vector index config checker to replace the config checker
bceca38 
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@foxspy foxspy force-pushed the remove_vector_index_config_checker branch from 9515e36 to bceca38 Compare October 25, 2024 07:41
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Oct 25, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 25, 2024
liliu-z
liliu-z reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

czs007
czs007 reviewed Oct 28, 2024
View reviewed changes
internal/util/indexparamcheck/index_type.go
IndexFaissHNSWPQ IndexType = "FAISS_HNSW_PQ"
IndexFaissHNSWSQ IndexType = "FAISS_HNSW_SQ"
IndexFaissHNSWPRQ IndexType = "FAISS_HNSW_PRQ"
IndexVector IndexType = "VECINDEX"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove this definition

@czs007
Copy link
Collaborator

czs007 commented Oct 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d7b2ffe into milvus-io:master Oct 28, 2024
15 of 17 checks passed
@zhengbuqian zhengbuqian mentioned this pull request Oct 29, 2024
Closed
1 task
@foxspy foxspy mentioned this pull request Oct 31, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Nov 1, 2024
@foxspy
enhance: [CP25]add unify vector index config management (#37331)
5aee184 
issue: #34298 
pr: #36844

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliu-z liliu-z liliu-z left review comments

@czs007 czs007 czs007 left review comments

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@czs007 czs007

@liliu-z liliu-z

Labels
approved area/compilation area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foxspy @liliu-z @czs007 @sre-ci-robot