Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add sorted for segment info #36469

Merged
merged 1 commit into from
Sep 30, 2024
Merged

enhance: Add sorted for segment info #36469

merged 1 commit into from
Sep 30, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #33744

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/internal-api size/M Denotes a PR that changes 30-99 lines. labels Sep 24, 2024
@xiaocai2333 xiaocai2333 force-pushed the add_sorted_for_segmentInfo branch from 97060c9 to 94db18e Compare September 24, 2024 07:53
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Sep 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the add_sorted_for_segmentInfo branch 3 times, most recently from ddaddac to 8232ce9 Compare September 25, 2024 02:18
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.69%. Comparing base (50905e0) to head (ac43189).
Report is 22 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #36469       +/-   ##
===========================================
- Coverage   82.31%   71.69%   -10.63%     
===========================================
  Files        1281     1281               
  Lines      151432   151451       +19     
===========================================
- Hits       124656   108580    -16076     
- Misses      21760    37858    +16098     
+ Partials     5016     5013        -3
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.86% <100.00%> (+0.05%) ⬆️
internal/datacoord/services.go 86.01% <100.00%> (+0.01%) ⬆️
internal/datacoord/util.go 98.43% <100.00%> (+0.03%) ⬆️
internal/proxy/impl.go 85.87% <100.00%> (+<0.01%) ⬆️
internal/querycoordv2/dist/dist_handler.go 95.78% <100.00%> (+0.02%) ⬆️
internal/querycoordv2/utils/types.go 80.32% <100.00%> (+0.32%) ⬆️
internal/querynodev2/segments/segment.go 68.53% <100.00%> (+0.06%) ⬆️
internal/querynodev2/services.go 91.10% <100.00%> (-0.41%) ⬇️
pkg/metrics/datacoord_metrics.go 63.23% <ø> (ø)
pkg/metrics/metrics.go 100.00% <ø> (ø)

... and 282 files with indirect coverage changes

@xiaocai2333 xiaocai2333 force-pushed the add_sorted_for_segmentInfo branch from 8232ce9 to 824f421 Compare September 25, 2024 07:57
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 25, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the add_sorted_for_segmentInfo branch from 824f421 to df5a77b Compare September 26, 2024 01:54
@xiaocai2333
Add sorted field for segment info returned to SDK
ac43189 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 force-pushed the add_sorted_for_segmentInfo branch from df5a77b to ac43189 Compare September 27, 2024 08:09
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 27, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 29, 2024
@czs007
Copy link
Collaborator

czs007 commented Sep 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ecb2b24 into milvus-io:master Sep 30, 2024
15 of 16 checks passed
@xiaocai2333 xiaocai2333 deleted the add_sorted_for_segmentInfo branch November 8, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@czs007 czs007

Labels
approved area/dependency Pull requests that update a dependency file area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot