Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for existing account when logging out #3082

Merged
merged 9 commits into from
Mar 8, 2024
Merged

fix: check for existing account when logging out #3082

merged 9 commits into from
Mar 8, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Feb 26, 2024 •
edited
Loading

Closes #2933

PR Type

Bugfix

Description of the changes

Check for existing active account when logging out.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner February 26, 2024 14:32
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

1 similar comment
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Feb 27, 2024
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Feb 28, 2024
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@Mnickii Mnickii requested a review from gavinbarron February 29, 2024 14:13
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

musale
musale previously approved these changes Feb 29, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@Mnickii Mnickii enabled auto-merge (squash) March 4, 2024 14:33
@gavinbarron
Copy link
Member

gavinbarron commented Mar 4, 2024 •
edited
Loading

@Mnickii Running this code using yarn start to use the developer test page and setting loginType: LoginType.Popup for the provider results in this error:
image

This is due to there not being an active account returned when calling active account in the repeated attempt to clear the localStorage item, suggest that we clean up that logout method in mgt-login to fix these issues.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

📖 The updated storybook is available here

@Mnickii Mnickii disabled auto-merge March 5, 2024 09:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

📖 The updated storybook is available here

@Mnickii Mnickii requested review from gavinbarron and removed request for gavinbarron March 6, 2024 17:58
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

📖 The updated storybook is available here

@Mnickii Mnickii requested a review from gavinbarron March 8, 2024 03:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 46% 100% 0 ❌
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 82% 100% 0 ✔
mgt-components.src.components.mgt-person-card 77% 49% 0 ✔
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0 ✔
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 78% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 27% 0 ✔
mgt-element.dist.es6.components.src.components 72% 73% 0 ➖
mgt-element.dist.es6.mock.src.mock 91% 73% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 76% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 67% 71% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 83% 100% 0 ✔
mgt-element.src.utils 71% 90% 0 ➖
Summary 67% (14504 / 21520) 74% (514 / 694) 0 ➖

@gavinbarron gavinbarron merged commit da77913 into main Mar 8, 2024
10 checks passed
@gavinbarron gavinbarron deleted the fix/mgt-login-console-bug branch March 8, 2024 19:06
@gavinbarron gavinbarron mentioned this pull request Mar 7, 2024
Merged
This was referenced Jun 8, 2024
Open
Open
This was referenced Jun 20, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@musale musale musale left review comments

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] When signing out using mgt-login, we're getting a console error
3 participants
@Mnickii @gavinbarron @musale