Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache builtin commands and get all global commands for pwsh #236570

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 19, 2024

This should make things quite a bit faster for expensive fetching of commands. This also caches empty builtin commands so it's not attempted every time.

Fixes #236097
Part of #235024

This should make things quite a bit faster for expensive fetching of
commands. This also caches empty builtin commands so it's not attempted
every time.

Fixes #236097
Part of #235024
@Tyriar Tyriar added this to the January 2025 milestone Dec 19, 2024
@Tyriar Tyriar requested a review from meganrogge December 19, 2024 10:51
@Tyriar Tyriar self-assigned this Dec 19, 2024
@Tyriar Tyriar enabled auto-merge December 19, 2024 10:52
@Tyriar Tyriar merged commit 8467007 into main Dec 19, 2024
8 checks passed
@Tyriar Tyriar deleted the tyriar/236097 branch December 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getBuiltinCommands should be cached
2 participants