Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve custom editor with canonical resource #226614

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

BABA983
Copy link
Contributor

@BABA983 BABA983 commented Aug 26, 2024

Close #146732

In textModelResolverService will return a canonical URI which leads to different URI in extension host.

@BABA983
Copy link
Contributor Author

BABA983 commented Sep 10, 2024

@mjbvz Could you take a look at this PR? Thanks!

@mjbvz mjbvz added this to the January 2025 milestone Dec 17, 2024
@mjbvz mjbvz enabled auto-merge December 17, 2024 20:05
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's try this out in insiders to verify it fixes the problem and doesn't cause any regressions

@mjbvz mjbvz merged commit ad09e3d into microsoft:main Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-only rename fails if custom editor active
3 participants