Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to electron 30 #215406

Merged
merged 14 commits into from
Jul 9, 2024
Merged

chore: update to electron 30 #215406

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
02fdf6a
chore: update electron@30.0.9
deepak1556 Jun 13, 2024
176ccd1
chore: update rpm deps
deepak1556 Jun 13, 2024
1973428
chore: bump electron@30.1.2
deepak1556 Jul 3, 2024
2742f5a
fix: update kerberos for Node.js 20.x
deepak1556 Jul 3, 2024
fdf4449
fix: use shell when spawning .bat or .cmd files
deepak1556 Jun 26, 2024
ccc5c97
fix: update @vscode/test-electron@2.4.0
deepak1556 Jul 3, 2024
b7a67b5
fixup! use shell when spawning .bat or .cmd files
deepak1556 Jul 6, 2024
cb60a8f
chore: bump nodejs@20.14.0 internal build
deepak1556 Jul 7, 2024
393fd36
ci: skip nodejsMirror for 20.14.0 due to missing builds
deepak1556 Jul 8, 2024
e7bdc85
fixup! use shell when spawning .bat or .cmd files
deepak1556 Jul 8, 2024
4998227
chore: update debian deps
deepak1556 Jul 8, 2024
bde1039
fixup! skip nodejsMirror for 20.14.0 due to missing builds
deepak1556 Jul 8, 2024
fb736fe
fix: universal build
deepak1556 Jul 8, 2024
afda215
chore: bump distro
deepak1556 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use shell when spawning .bat or .cmd files 
Refs nodejs/node@6627222409
  • Loading branch information
@deepak1556
deepak1556 committed Jul 9, 2024
commit fdf4449559d2d063430c901e9a39c20d85b8fd8e
8 changes: 4 additions & 4 deletions extensions/vscode-test-resolver/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ export function activate(context: vscode.ExtensionContext) {
const serverCommandPath = path.join(vscodePath, 'scripts', serverCommand);

outputChannel.appendLine(`Launching server: "${serverCommandPath}" ${commandArgs.join(' ')}`);

extHostProcess = cp.spawn(serverCommandPath, commandArgs, { env, cwd: vscodePath });
const shell = (process.platform === 'win32');
extHostProcess = cp.spawn(serverCommandPath, commandArgs, { env, cwd: vscodePath, shell });
} else {
const extensionToInstall = process.env['TESTRESOLVER_INSTALL_BUILTIN_EXTENSION'];
if (extensionToInstall) {
Expand All @@ -182,8 +182,8 @@ export function activate(context: vscode.ExtensionContext) {

outputChannel.appendLine(`Using server build at ${serverLocation}`);
outputChannel.appendLine(`Server arguments ${commandArgs.join(' ')}`);

extHostProcess = cp.spawn(path.join(serverLocation, 'bin', serverCommand), commandArgs, { env, cwd: serverLocation });
const shell = (process.platform === 'win32');
extHostProcess = cp.spawn(path.join(serverLocation, 'bin', serverCommand), commandArgs, { env, cwd: serverLocation, shell });
}
extHostProcess.stdout!.on('data', (data: Buffer) => processOutput(data.toString()));
extHostProcess.stderr!.on('data', (data: Buffer) => processOutput(data.toString()));
Expand Down