Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt l10n for extension-editing #165523

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Adopt l10n for extension-editing #165523

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c11c146
Adopt l10n for extension-editing
mjbvz Nov 4, 2022
90c131f
Fix import
mjbvz Nov 4, 2022
335e1bd
Also update eslint rule
mjbvz Nov 4, 2022
06d4481
Merge branch 'main' into secure-ostrich
mjbvz Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also update eslint rule
  • Loading branch information
@mjbvz
mjbvz committed Nov 4, 2022
commit 335e1bde656a73444e54be812d68350f51f1d8e8
8 changes: 8 additions & 0 deletions .eslintplugin/code-no-unexternalized-strings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,16 @@ export = new class NoUnexternalizedStrings implements eslint.Rule.RuleModule {
return {
['Literal']: (node: any) => collectDoubleQuotedStrings(node),
['ExpressionStatement[directive] Literal:exit']: (node: any) => doubleQuotedStringLiterals.delete(node),

// localize(...)
['CallExpression[callee.type="MemberExpression"][callee.object.name="nls"][callee.property.name="localize"]:exit']: (node: any) => visitLocalizeCall(node),

// vscode.l10n.t(...)
['CallExpression[callee.type="MemberExpression"][callee.object.property.name="l10n"][callee.property.name="t"]:exit']: (node: any) => visitL10NCall(node),

// l10n.t(...)
['CallExpression[callee.object.name="l10n"][callee.property.name="t"]:exit']: (node: any) => visitL10NCall(node),

['CallExpression[callee.name="localize"][arguments.length>=2]:exit']: (node: any) => visitLocalizeCall(node),
['Program:exit']: reportBadStringsAndBadKeys,
};
Expand Down