Skip to content

"Toggle Panel Visibility" stopped setting terminalFocus #236443

Closed
@ulugbekna

Description

Repro:

  1. Have the keybinding below
  2. Focus editor
  3. Toggle panel visibility (cmd+j)
  4. Press cmd+n -- on stable, this launches a new terminal, while on insiders, it creates a new editor
  {
    "key": "cmd+n",
    "command": "workbench.action.terminal.new",
    "when": "terminalFocus"
  },

Version: 1.97.0-insider
Commit: 95386de
Date: 2024-12-17T05:04:19.511Z
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.2.0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions