Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Key collision for test run parameters #328

Merged
merged 8 commits into from
Dec 6, 2017
Merged

Fixing Key collision for test run parameters #328

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
96faa96
Base commit
jayaranigarg Dec 6, 2017
ed8f27c
Adding Unit Test
jayaranigarg Dec 6, 2017
bf1bf88
Merge branch 'master' into keycollisionfix
jayaranigarg Dec 6, 2017
ddee7e5
PR comments
jayaranigarg Dec 6, 2017
bfd4da6
Merge branch 'keycollisionfix' of https://github.com/jayaranigarg/tes…
jayaranigarg Dec 6, 2017
1dd31e3
Adding logs for diagnostics
jayaranigarg Dec 6, 2017
2953910
Ignoring Test Temporarily
jayaranigarg Dec 6, 2017
fe747b3
Removing ignore
jayaranigarg Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR comments
  • Loading branch information
@jayaranigarg
jayaranigarg committed Dec 6, 2017
commit ddee7e56f0e2d6243aca50f9bbf6af68f9293b0c
4 changes: 1 addition & 3 deletions test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,7 @@ public void RunTestsShouldClearSessionParametersAcrossRuns()
// Trigger another Run
this.TestExecutionManager.RunTests(tests, this.runContext, this.frameworkHandle, new TestRunCancellationToken());

CollectionAssert.Contains(
DummyTestClass.TestContextProperties.ToList(),
new KeyValuePair<string, object>("webAppUrl", "http://updatedLocalHost"));
Assert.AreEqual(DummyTestClass.TestContextProperties["webAppUrl"], "http://updatedLocalHost");
}

#endregion
Expand Down