[heft-sass] Allow suppressing SASS deprecation warnings (#4958)

Co-authored-by: David Michon <dmichon-msft@users.noreply.github.com>
microsoft · Oct 3, 2024 · d45f132 · d45f132
1 parent dba45cb
commit d45f132
Show file tree

Hide file tree

Showing 9 changed files with 132 additions and 104 deletions.
diff --git a/build-tests/heft-sass-test/config/sass.json b/build-tests/heft-sass-test/config/sass.json
@@ -3,5 +3,7 @@
 
   "cssOutputFolders": ["lib", "lib-commonjs"],
   "secondaryGeneratedTsFolders": ["lib"],
-  "excludeFiles": ["./ignored1.scss", "ignored2.scss"]
+  "excludeFiles": ["./ignored1.scss", "ignored2.scss"],
+
+  "silenceDeprecations": ["mixed-decls"]
 }
diff --git a/build-tests/heft-sass-test/package.json b/build-tests/heft-sass-test/package.json
@@ -30,8 +30,6 @@
     "postcss": "~8.4.6",
     "react-dom": "~17.0.2",
     "react": "~17.0.2",
-    "sass-loader": "~10.0.0",
-    "sass": "~1.3.0",
     "style-loader": "~2.0.0",
     "typescript": "~5.4.2",
     "webpack": "~4.47.0"

diff --git a/common/changes/@rushstack/heft-sass-plugin/sass-silence-deprecations_2024-10-02-01-20.json b/common/changes/@rushstack/heft-sass-plugin/sass-silence-deprecations_2024-10-02-01-20.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft-sass-plugin",
+      "comment": "Add \"suppressDeprecations\" option to suppress specific SASS deprecation IDs. Add \"ignoreDeprecationsInDependencies\" option to ignore deprecation warnings from external SASS.",
+      "type": "minor"
+    }
+  ],
+  "packageName": "@rushstack/heft-sass-plugin"
+}
diff --git a/common/config/subspaces/default/pnpm-lock.yaml b/common/config/subspaces/default/pnpm-lock.yaml
diff --git a/common/config/subspaces/default/repo-state.json b/common/config/subspaces/default/repo-state.json
@@ -1,5 +1,5 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "0c6b3b92849c042aeab9c7f8751d9698d6accb04",
+  "pnpmShrinkwrapHash": "5afee1d392a0c2404869d7eda687b5571fe88515",
   "preferredVersionsHash": "ce857ea0536b894ec8f346aaea08cfd85a5af648"
 }
diff --git a/heft-plugins/heft-sass-plugin/package.json b/heft-plugins/heft-sass-plugin/package.json
@@ -22,7 +22,7 @@
     "@rushstack/heft-config-file": "workspace:*",
     "@rushstack/node-core-library": "workspace:*",
     "@rushstack/typings-generator": "workspace:*",
-    "sass-embedded": "~1.77.2",
+    "sass-embedded": "~1.77.8",
     "postcss": "~8.4.6",
     "postcss-modules": "~6.0.0"
   },